refactor(tag): refactor tag component used by composition #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higuaifan
changed the title
|
|
|
新年快乐，休假中，CR可能会比较慢 |
新年快乐🎉 ，大佬们辛苦了，别卷了，休假就休假吧（狗头） |
PengYYYYY
reviewed
Feb 9, 2022
code review details is in pr #273
higuaifan
commented
Feb 9, 2022
|
@PengYYYYY CR的问题已修复，不过有个写法感觉有点奇怪，麻烦看一下。 |
tag component changed tagClass array item's order , so update snapshots.
|
处理一下冲突 |
…onAPI # Conflicts: # src/tag/check-tag.tsx # src/tag/tag.tsx # test/unit/tag/__snapshots__/demo.test.js.snap # test/unit/tag/__snapshots__/index.test.js.snap
after merge upstream overwrite old snap , so update snapshots.
some component snapshots contains tag component, so need update snapshots.
已处理，并且处理了下 |
|
看下lint问题喔 |
已修复。。辛苦了。 |
PengYYYYY
approved these changes
Feb 14, 2022
PengYYYYY
pushed a commit
that referenced
this pull request
Feb 16, 2022
code review details is in pr #273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
vue3 composition API重构tag和check-tag组件；#58
💡 需求背景和解决方案
configReceiver改为使用useReceiver;emitEvent改为使用useEmitEvent;methods和computed迁移到了setup中；📝 更新日志
☑️ 请求合并前的自查清单