Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Loading): hide loading will remove app instance when use plugin or directive call #3576

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

Zz-ZzzZ
Copy link
Contributor

@Zz-ZzzZ Zz-ZzzZ commented Nov 7, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#3540

💡 需求背景和解决方案

📝 更新日志

  • feat(Loading): 当使用 Plugin 或指令调用时,隐藏 Loading 将会移除 app 实例(issue #3540)

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@Zz-ZzzZ Zz-ZzzZ changed the title feat(Loading): hide loading will be remove app instance when use plugin or directive call feat(Loading): hide loading will remove app instance when use plugin or directive call Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

完成

@uyarn
Copy link
Collaborator

uyarn commented Nov 7, 2023

@Zz-ZzzZ 麻烦 rebase 下 develop 有个ci问题刚刚修复了

@Zz-ZzzZ
Copy link
Contributor Author

Zz-ZzzZ commented Nov 7, 2023

@uyarn 看下这样ok吗

@PengYYYYY PengYYYYY merged commit 097df94 into Tencent:develop Nov 12, 2023
5 checks passed
This was referenced Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants