fix: 通过正则匹配space,误判断删除键(backspace)是空格键(space) #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweijie0812
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
liweijie0812
changed the title
uyarn
approved these changes
Nov 11, 2023
16 tasks
chaishi
reviewed
Nov 23, 2023
| @@ -1,8 +1,8 @@ | |||
| export const CHECKED_CODE_REG = /(enter|space)/i; | |||
| export const CHECKED_CODE = ['Enter', 'Space']; | |||
There was a problem hiding this comment.
辛苦调整 /(enter|space)/i 为 /^(enter|space)$/i;
而非改为数组
There was a problem hiding this comment.
分两步改
先把 CHECKED_CODE_REG 定义改到common Tencent/tdesign-common#1656
再来改框架的
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#3598
空格space, 删除backspace ,正则判断space，触发删除键误判断是空格
💡 需求背景和解决方案
📝 更新日志
fix(Radio):
useKeyboard通过正则匹配space,误判断删除键(backspace)是空格键(space)fix(Checkbox):
useKeyboardEvent通过正则匹配space,误判断删除键(backspace)是空格键(space)本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单