Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input): support number type #3600

Merged
merged 3 commits into from
Nov 20, 2023
Merged

feat(input): support number type #3600

merged 3 commits into from
Nov 20, 2023

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Nov 12, 2023 •
edited

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Input): value 支持数据类型 number

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2023 •
edited

完成

@chaishi chaishi mentioned this pull request Nov 12, 2023
Merged
16 tasks
@PengYYYYY
Copy link
Collaborator

Screen.Recording.2023-11-15.at.22.58.31.mov

原生的 input 组件，type=number 时，空值为空字符串。TD 目前为 undefined，此处是否需要跟原生 input 保持一致。

PengYYYYY
PengYYYYY reviewed Nov 15, 2023
View reviewed changes
src/input/useInput.ts Outdated Show resolved Hide resolved
src/input/useInput.ts Outdated Show resolved Hide resolved
@chaishi
Copy link
Collaborator Author

chaishi commented Nov 18, 2023

原生的 input 组件，type=number 时，空值为空字符串。TD 目前为 undefined，此处是否需要跟原生 input 保持一致

不需要，type=number，就是数字，不应该是 ''。本次修改的目的就是为了支持数字类型，全套数字

@PengYYYYY PengYYYYY merged commit 0fae504 into Tencent:develop Nov 20, 2023
5 checks passed
This was referenced Nov 22, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chaishi @PengYYYYY