fix(dialog): 🐛 修正获取元素操作的时机,移动到mounted之后进行,确保可以获取到挂载元素 #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cat1007
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
PengYYYYY
reviewed
Dec 13, 2023
PengYYYYY
approved these changes
Dec 15, 2023
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
在使用className和destoryOnClose的时候，会存在获取元素的操作早于元素挂载时机的问题
复现demo如下：
https://stackblitz.com/edit/myaamn?file=src%2Fdemo.vue
移动了updateClassName的逻辑，延迟到组件 mounted 后下一个 tick 执行
📝 更新日志
fix(DialogPlugin): 修正获取元素操作
className的时机本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单