Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): the checked state also triggers the change event #3782

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

betavs
Copy link
Contributor

@betavs betavs commented Dec 27, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #3781

💡 需求背景和解决方案

📝 更新日志

  • fix(Radio): 处理选中状态也会触发 change 事件的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

完成

@betavs
Copy link
Contributor Author

betavs commented Dec 27, 2023

现在想起来 这个好像合了好像也不太合适 Tencent/tdesign-vue#3000 本来的issue感觉并不是问题

如果已经选中并且 allowUncheckfalse 的情况下,再次点击应该不会触发 change 事件的 🤔

@uyarn
Copy link
Collaborator

uyarn commented Dec 27, 2023

现在想起来 这个好像合了好像也不太合适 Tencent/tdesign-vue#3000 本来的issue感觉并不是问题

如果已经选中并且 allowUncheckfalse 的情况下,再次点击应该不会触发 change 事件的 🤔

嗯 我刚刚想成多选的了

@uyarn uyarn merged commit f36cf3d into Tencent:develop Dec 27, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Radio] the checked state also triggers the change event
2 participants