Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tree): migrate OptionsApi to CompositionAPI #3899

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Jan 29, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

Vue3 的示例代码以 CompositionAPI 为主,减少刚入门 Vue 的开发同学阅读成本

🔗 相关 Issue

💡 需求背景和解决方案

使用工具自动转的,已在线验证示例代码,表现正常

📝 更新日志

  • docs(tree): 示例代码由 OptionsAPI 更为 CompositionAPI

同时 createElement 跟随 Vue3 导出的 h 函数,统一命名为 h

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Jan 29, 2024

完成

@uyarn uyarn merged commit 7e8b873 into Tencent:develop Jan 29, 2024
5 checks passed
@TabSpace
Copy link
Contributor

下面备注之后需要检查修正的调试用示例。

@TabSpace
Copy link
Contributor

TabSpace commented Jan 29, 2024

企业微信截图_96ae3ed8-e74a-438d-b8af-a38e9186dc63

http://localhost:17000/vue-next/demos/tree/controlled

受控开关失效。

@TabSpace
Copy link
Contributor

TabSpace commented Jan 29, 2024

企业微信截图_be9eb1d0-5a8a-4e41-92bf-03062cfe7d30

http://localhost:17000/vue-next/demos/tree/debug-data

数据切换报错。

@TabSpace
Copy link
Contributor

http://localhost:17000/vue-next/demos/tree/expand-all

数据切换报错。

@TabSpace
Copy link
Contributor

http://localhost:17000/vue-next/demos/tree/load
http://localhost:16000/vue/demos/tree/load

两边示例存在同样问题,选中态无法变更,应提供选中态可操作的示例

@TabSpace
Copy link
Contributor

http://localhost:17000/vue-next/demos/tree/operations
http://localhost:16000/vue/demos/tree/operations

两边示例存在同样问题,高亮节点难以区分

@chaishi
Copy link
Collaborator Author

chaishi commented Jan 29, 2024

resolved below problems in https://github.com/Tencent/tdesign-vue-next/pull/3902/files

@github-actions github-actions bot mentioned this pull request Jan 31, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants