Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(badge): use composition api to refactor badge component #402

Merged
merged 3 commits into from Mar 8, 2022
Merged

refactor(badge): use composition api to refactor badge component #402

merged 3 commits into from Mar 8, 2022

Conversation

ChrisLee0211
Copy link
Contributor

#58

🤔 这个 PR 的性质是?

  • 是关于什么的改动?
    refactor badge component used by composition

🔗 相关 Issue

#58

💡 需求背景和解决方案

  1. 使用computed计算属性导出样式和内容计算逻辑,减少原先method冗余声明

📝 更新日志

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

完成

src/badge/badge.tsx Outdated Show resolved Hide resolved
src/badge/badge.tsx Outdated Show resolved Hide resolved
@PengYYYYY PengYYYYY merged commit be4b44c into Tencent:compositionAPI Mar 8, 2022
@PengYYYYY PengYYYYY mentioned this pull request Mar 8, 2022
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants