Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading): hide incorrectly close instance (#4036) #4081

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

XBIsland
Copy link
Contributor

@XBIsland XBIsland commented Apr 6, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. fullScreenLoadingInstance 全屏返回单例。
  2. 优化 Loading 文档与演示代码。

📝 更新日志

  • fix(loading): hide 函数错误关闭所有 Loading 实例.

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Apr 6, 2024

完成

@uyarn
Copy link
Collaborator

uyarn commented Apr 8, 2024

npm run test:update

@uyarn uyarn merged commit ef3320c into Tencent:develop Apr 8, 2024
5 checks passed
@XBIsland XBIsland deleted the fix/loading branch April 10, 2024 09:25
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants