fix(popup): disappear when mounted within webcomponent shadow root #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decadef20
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
uyarn
reviewed
Apr 10, 2024
decadef20
force-pushed
the
feautre/webcomponent-popup
branch
from
d21b0cd
to
aaa98d5
Compare
uyarn
changed the title
uyarn
approved these changes
Apr 10, 2024
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(Popup): 修复在 webcomponent 场景下由于shadowroot 导致document判断异常引起的展示问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单