Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Slider): refactor slider component used by composition #552

Merged
merged 11 commits into from Apr 9, 2022

Conversation

ChrisLee0211
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#58
#544

💡 需求背景和解决方案

  • 使用composition api完全重构slider
  • 将slider内部input模式、刻度值模式和popup交互分别聚合为hook管理
  • 精简无用变量与方法
  • 替换mapProps

📝 更新日志

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

完成

src/slider/slider-button.tsx Outdated Show resolved Hide resolved
src/slider/slider-button.tsx Outdated Show resolved Hide resolved
src/slider/slider-button.tsx Outdated Show resolved Hide resolved
src/slider/slider-button.tsx Outdated Show resolved Hide resolved
src/slider/slider-button.tsx Outdated Show resolved Hide resolved
src/slider/slider-button.tsx Outdated Show resolved Hide resolved
src/slider/props.ts Show resolved Hide resolved
src/slider/slider.tsx Outdated Show resolved Hide resolved
src/slider/slider.tsx Outdated Show resolved Hide resolved
@PengYYYYY PengYYYYY merged commit 00118dd into Tencent:compositionAPI Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants