Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] 弹窗组件如果初始默认显示,按esc关不掉 #2608

Closed
vonlyinno opened this issue Jul 24, 2023 · 4 comments
Closed

[Dialog] 弹窗组件如果初始默认显示,按esc关不掉 #2608

vonlyinno opened this issue Jul 24, 2023 · 4 comments
Assignees
Labels
🐞 bug Something isn't working to be published fixed, not be published

Comments

@vonlyinno
Copy link

vonlyinno commented Jul 24, 2023

tdesign-vue 版本

1.4.7

重现链接

https://stackblitz.com/edit/igrydh?file=src%2Fdemo.vue

重现步骤

弹窗组件初始默认显示,或者使用了v-if,不会触发 esc的监听。

应该是默认显示或者v-if,导致visible初始就是true,没有触发组件内部对visible的watch

企业微信截图_f80a9e8a-9aa6-4664-8308-8d586cfd5ec0

期望结果

No response

实际结果

No response

框架版本

2.6.14

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response

@github-actions
Copy link
Contributor

👋 @vonlyinno,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

♥️ 有劳 @zhaodanchun @chaishi @Zack921 @huoyuhao 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @vonlyinno

@xiaosansiji xiaosansiji added the 🐞 bug Something isn't working label Aug 14, 2023
@Zhanjiachun
Copy link
Contributor

认领该任务,截止时间23号前完成提交

@Zhanjiachun Zhanjiachun mentioned this issue Aug 17, 2023
16 tasks
@uyarn uyarn added the to be published fixed, not be published label Aug 21, 2023
xiaosansiji pushed a commit that referenced this issue Aug 31, 2023
* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)
@uyarn
Copy link
Collaborator

uyarn commented Sep 6, 2023

fixed in 1.6.5

@uyarn uyarn closed this as completed Sep 6, 2023
uyarn pushed a commit that referenced this issue Sep 22, 2023
* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)
chaishi added a commit that referenced this issue Sep 22, 2023
* fix(table): tree.defaultExpandAll (#2752)

* Fix0817 (#2708)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix: 弹窗组件如果初始默认显示, 按esc关不掉问题修复 (#2608)

* fix(checkbox): multitple checkbox-group exist at the page (#2768)

* fix(checkbox): multitple checkboxgroup

* fix(table): unique key

* feat(table): fix resetValue does not work on clear filter;

* fix(form): fix reset form error (#2760)

Co-authored-by: zhangjiancheng <zhangjiancheng@aibaoxian.com>

* feat(table): fix false value can not highlight filter icon; support filter.label (#2771)

* fix(table): support filter value which is false can highlight filter icon

* feat(table): support filter.label

* docs(table): update demove

* fix(table): title is a function

* fix: lint error

* fix(image): dulplicate preview icon (#2770)

* fix(image): dulplicate preview icon

* fix(image): fix preview url

* fix(table): lint error

* test: update snapshots

* feat(dialog): confirmLoading (#2769)

* feat(dialog): confirmLoading

* test: update snapshots

* fix(popup): clear queued open action caused by accident (#2747)

* Revert "fix(popup): clear queued open action caused by accident (#2747)" (#2775)

This reverts commit e1a1f95.

* fix: fix bundle content (#2776)

* fix: fix remove listener hook (#2777)

* fix(loading): fix loading false create instance again (#2778)

* fix(Select): fix delete exist option when delete input value (#2779)

* feat: release 1.6.5 (#2774)

* feat: release 1.6.5

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(checkbox): group dynamic (#2793)

* fix(table): multiple editable table (#2787)

* fix(table): multiple editable table

* docs(dialog): demo

* chore: release 1.6.6 (#2795)

* chore: 1.6.6

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(treeselect): support panel content API (#2797)

* fix: useResizeObserver (#2806)

* chore: update README (#2808)

* feat(table): support group columns (#2810)

* feat(table): column controller

* test(table): update snapshots

* fix(table): props.locale

* fix: lint error

* fix: lint error

* fix(dialog): Dialog component support confirmLoading (#2814)

* fix(dialog): confirmLoading

* docs(dialog): remove docs

* feat(card): replace title span with div (#2812)

* feat(card): replace title span with div

* feat(card): replace title span with div

* chore: release 1.6.7 (#2817)

* chore: release 1.6.7

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: release 1.6.7-naruto

* chore: release 1.6.7-naruto

---------

Co-authored-by: sheepluo <yaoyanhuoyi@qq.com>
Co-authored-by: Zhanjiachun <49758402+Zhanjiachun@users.noreply.github.com>
Co-authored-by: Zz-ZzzZ <48228016+Zz-ZzzZ@users.noreply.github.com>
Co-authored-by: zhangjiancheng <zhangjiancheng@aibaoxian.com>
Co-authored-by: ikeq <ikeq@foxmail.com>
Co-authored-by: azhe <xiaosansiji@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working to be published fixed, not be published
Projects
None yet
Development

No branches or pull requests

5 participants