Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): fix events after use t-input #1075

Merged
merged 3 commits into from
Jun 26, 2022

Conversation

jchalex
Copy link
Contributor

@jchalex jchalex commented Jun 26, 2022

fix #1033

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1033

💡 需求背景和解决方案

  1. 要解决的具体问题:1)enter 事件应从 keypress 监听,keydown 监听不到;2)事件响应出错
  2. 列出最终的 API 实现和用法:1)enter 事件转移至 keypress 下监听;2)PR 541 将原生 input 更新为了 t-input,Event 参数需一起由1个变成2个
  3. 涉及UI/交互变动需要有截图或 GIF:

修改前:
image

修改后:
image

📝 更新日志

  • fix(input-number): enter 等事件响应

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #1075 (2b3b602) into develop (a0db0df) will increase coverage by 1.95%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1075      +/-   ##
===========================================
+ Coverage    57.56%   59.51%   +1.95%     
===========================================
  Files          346      406      +60     
  Lines        12828    15002    +2174     
  Branches      2405     2800     +395     
===========================================
+ Hits          7384     8929    +1545     
- Misses        5200     5803     +603     
- Partials       244      270      +26     
Impacted Files Coverage Δ
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/date-picker/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/affix/affix.tsx 39.06% <0.00%> (-27.01%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/select/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/message/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/tooltip/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7de0c...2b3b602. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2022

完成

@uyarn
Copy link
Collaborator

uyarn commented Jun 26, 2022

LGTM

@uyarn uyarn merged commit 22c30ba into Tencent:develop Jun 26, 2022
@github-actions github-actions bot mentioned this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InputNumber] enter事件无法触发
3 participants