Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ConfigProvider): 修复 config-provider 同时存在 provide 和 setup#provide 导致卡顿的性能问题 #1113

Merged
merged 3 commits into from
Jul 2, 2022

Conversation

Ryqsky
Copy link
Contributor

@Ryqsky Ryqsky commented Jul 2, 2022

…导致卡顿的性能问题

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

目前在内存较大的页面再 window.open() tdesign 的表格组件,此时会卡顿,最根本原因是 config-provider 提供了两种 provide,导致有冲突,改成一种形式即可解决

📝 更新日志

  • fix(ConfigProvider): 修复 config-provider 同时存在 provide 和 setup#provide 导致卡顿的性能问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1113 (4e5dc23) into develop (a0db0df) will increase coverage by 1.73%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1113      +/-   ##
===========================================
+ Coverage    57.56%   59.29%   +1.73%     
===========================================
  Files          346      406      +60     
  Lines        12828    15054    +2226     
  Branches      2405     2824     +419     
===========================================
+ Hits          7384     8927    +1543     
- Misses        5200     5855     +655     
- Partials       244      272      +28     
Impacted Files Coverage Δ
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/date-picker/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/drawer/props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/pagination/props.ts 72.72% <0.00%> (-27.28%) ⬇️
src/affix/affix.tsx 39.06% <0.00%> (-27.01%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/select/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 220 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a7ced...4e5dc23. Read the comment docs.

@chaishi chaishi merged commit 7356ff5 into Tencent:develop Jul 2, 2022
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants