Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): editable row support #1182

Merged
merged 8 commits into from
Jul 18, 2022

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Jul 16, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(table): 可编辑单元格,修复 onEnter 无法触发 onEdited 问题

  • fix(table): 可编辑单元格,一旦校验不通过,后续编辑无法退出编辑态问题

  • feat(table): 新增可编辑行的表格

  • feat(table): 可编辑单元格/可编辑行,新增 showEditIcon,用于控制是否显示编辑图标

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #1182 (5d2d79d) into develop (aaf0135) will decrease coverage by 0.23%.
The diff coverage is 20.17%.

@@             Coverage Diff             @@
##           develop    #1182      +/-   ##
===========================================
- Coverage    58.80%   58.56%   -0.24%     
===========================================
  Files          405      406       +1     
  Lines        15051    15138      +87     
  Branches      2844     2857      +13     
===========================================
+ Hits          8851     8866      +15     
- Misses        5927     5999      +72     
  Partials       273      273              
Impacted Files Coverage Δ
src/table/base-table-props.ts 61.53% <ø> (ø)
src/table/base-table.tsx 79.52% <ø> (ø)
src/table/editable-cell.tsx 7.03% <0.00%> (-2.41%) ⬇️
src/table/hooks/tree-store.ts 10.39% <ø> (ø)
src/table/hooks/useClassName.ts 100.00% <ø> (ø)
src/table/utils.ts 46.15% <14.28%> (-2.66%) ⬇️
src/table/hooks/useEditableRow.ts 27.08% <27.08%> (ø)
src/table/primary-table.tsx 84.00% <35.71%> (-5.57%) ⬇️
src/table/hooks/useEditableCell.tsx 100.00% <100.00%> (ø)
src/table/hooks/useRowSelect.tsx 60.56% <100.00%> (-1.09%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d171ff4...5d2d79d. Read the comment docs.

@uyarn uyarn changed the title editable row support feat(Table): editable row support Jul 18, 2022
@uyarn uyarn merged commit 42c694f into Tencent:develop Jul 18, 2022
This was referenced Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants