Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): fix loading status for ghost button #1432

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

DevinXian
Copy link
Contributor

@DevinXian DevinXian commented Aug 31, 2022

fix #1246

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

区分 button 组件 loading 和 disabled 状态,并修改 styles

📝 更新日志

  • fix(Button): 修复幽灵按钮 loading 状态背景色

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1432 (a150ef7) into develop (492d477) will increase coverage by 2.65%.
The diff coverage is 90.99%.

@@             Coverage Diff             @@
##           develop    #1432      +/-   ##
===========================================
+ Coverage    57.94%   60.60%   +2.65%     
===========================================
  Files          407      646     +239     
  Lines        15371    16151     +780     
  Branches      2931     2931              
===========================================
+ Hits          8907     9788     +881     
+ Misses        6187     6069     -118     
- Partials       277      294      +17     
Impacted Files Coverage Δ
src/alert/_example/icon.vue 100.00% <ø> (ø)
src/alert/_usage/index.vue 0.00% <ø> (ø)
src/anchor/_usage/index.vue 0.00% <ø> (ø)
src/avatar/_example/base.vue 100.00% <ø> (ø)
src/avatar/_usage/index.vue 0.00% <ø> (ø)
src/badge/_usage/index.vue 0.00% <ø> (ø)
src/breadcrumb/_example/custom.vue 100.00% <ø> (ø)
src/breadcrumb/_example/dropdown.vue 100.00% <ø> (ø)
src/button/_example/icon.vue 100.00% <ø> (ø)
src/button/_usage/index.vue 0.00% <ø> (ø)
... and 453 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DevinXian DevinXian force-pushed the devinxian/20220831_fix_button branch from a150ef7 to da0fa06 Compare August 31, 2022 15:44
@uyarn uyarn merged commit 3a25ba1 into Tencent:develop Aug 31, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button]ghost loading按钮文字消失
3 participants