Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upload][Refactor] #1561

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Sep 24, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • 新增beforeAllFilesUpload,所有文件上传之前执行,支持一次性判定所有文件是否继续上传。已经存在的 beforeUpload 用于判定单个文件的是否继续上传

  • 新增事件 onValidate,文件校验不通过时触发,可能情况有:自定义全文件校验不通过、文件数量校验不通过、文件数量校验不通过

  • 新增事件 onOneFileSuccess ,多文件上传场景下,在单个文件上传成功后触发

  • beforeUpload 存在时,依然支持 sizeLimit 检测

  • formatRequest 用于新增或修改上传请求参数

  • 一个请求上传多个文件,参数携带全部文件

  • 新增 triggerButtonProps 用于指定触发按钮风格

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Merging #1561 (efdc423) into develop (492d477) will increase coverage by 4.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1561      +/-   ##
===========================================
+ Coverage    57.94%   62.02%   +4.07%     
===========================================
  Files          407      677     +270     
  Lines        15371    16113     +742     
  Branches      2931     2794     -137     
===========================================
+ Hits          8907     9994    +1087     
+ Misses        6187     5832     -355     
- Partials       277      287      +10     
Impacted Files Coverage Δ
src/range-input/range-input-popup-props.ts 25.00% <0.00%> (-75.00%) ⬇️
src/grid/row-props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/select/util.ts 65.00% <0.00%> (-26.67%) ⬇️
src/select/props.ts 54.54% <0.00%> (-20.46%) ⬇️
src/affix/affix.tsx 22.72% <0.00%> (-16.34%) ⬇️
src/date-picker/props.ts 53.84% <0.00%> (-16.16%) ⬇️
src/upload/props.ts 58.33% <0.00%> (-13.10%) ⬇️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/select/optionGroup.tsx 31.57% <0.00%> (-9.60%) ⬇️
src/cascader/props.ts 55.55% <0.00%> (-8.74%) ⬇️
... and 472 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaosansiji xiaosansiji merged commit d0fca45 into Tencent:develop Sep 26, 2022
@github-actions github-actions bot mentioned this pull request Sep 28, 2022
@xixileng
Copy link
Contributor

onOneFileSuccess 这个是多选单文件成功触发
onOneFileFail 这个却是多选单选都会触发🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants