Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): fix single panel with enable-time-picker not available #2353

Conversation

Ericleungs
Copy link
Contributor

🤔 这个 PR 的性质是?

  • [√] 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#2279

💡 需求背景和解决方案

组件单独使用的时候并没有传递popupVisible属性,本身在单独使用的时候并没有父组件为date-picker-panel & date-range-picker-panel传递该属性,导致在single-panel(time-picker/panel/single-panel.tsx)中handleScroll方法对props.isShowPanel判断结果为真,卷动无法继续运行

📝 更新日志

添加了popupVisible属性

  • fix(date-picker): 修复单独的panel拎出来并且启用enable-time-picker时,时分秒无法双向绑定且无法滚动的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [√] 文档已补充或无须补充
  • [√] 代码演示已提供或无须提供
  • [√] TypeScript 定义已补充或无须补充
  • [√] Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2023

完成

@honkinglin honkinglin merged commit b07606a into Tencent:develop Apr 26, 2023
5 checks passed
This was referenced Apr 27, 2023
KMethod pushed a commit to KMethod/tdesign-vue that referenced this pull request Aug 25, 2023
…le (Tencent#2353)

* fix(datepicker): fix single panel with enable-time-picker not available

* fix(datepicker): edit the type of popupVisible

* refactor(date-picker): change popupVisible from props into attrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants