Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Textarea): autosize nextTick null err #2921

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

nined9
Copy link
Contributor

@nined9 nined9 commented Nov 22, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#2912

💡 需求背景和解决方案

问题:value的改变往nextTick push了一次autosize计算,然后组件destroy了,之后nextTick执行计算去$refs里拿ref为null,导致了报错

解决方案:
autosize计算方法里判定ref为null直接return

📝 更新日志

  • fix(Textarea): autosize nextTick null err (#2912)

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@nined9
Copy link
Contributor Author

nined9 commented Nov 22, 2023

这个pr没有针对issue 2912说的t-textarea无法输入中文做处理。

那个问题在于,可编辑cell需要传入的edit component接受value参数和派发change事件。

但是目前的t-textarea组件在中文输入过程中不会派发change事件,只会派发input事件。所以只能说t-textarea暂不符合edit component的要求

解决方案可以自己实现一个textarea来满足需求,这是一个简单的示例

Copy link
Contributor

完成

@uyarn uyarn merged commit f7a7219 into Tencent:develop Nov 23, 2023
5 checks passed
@uyarn
Copy link
Collaborator

uyarn commented Nov 23, 2023

LGTM

@github-actions github-actions bot mentioned this pull request Nov 23, 2023
16 tasks
uyarn added a commit that referenced this pull request Nov 23, 2023
* fix(tree): tree 组件,解决 watch 回调时间过迟的问题 (#2873)

* fix(tree): tree 组件,解决 watch 回调时间过迟的问题

* style(tree): tree 组件,代码样式改进

* test(tree): tree 组件,完善单元测试,验证 mounted 赋值可在 nextTick 触发数据变更

* [cascader]选项disabled修改后,选项不是禁用状态#2859 (#2872)

* [cascader]选项disabled修改后,选项不是禁用状态#2859

* chore: fix lint

---------

Co-authored-by: wū yāng <uyarnchen@gmail.com>

* feat(tree): add api getTreeData (#2888)

* refactor(tree): tree 组件完善数据初始化时机问题的解决方案

* feat(tree): tree 组件添加 api: getTreeData

* test(tree): tree 组件,完善 getTreeData 方法的单元测试

* test(tree): 完善单元测试

* docs(tree): tree 组件完善文档

* feat(upload): support fileListDisplay=null to hide file list (#2889)

* feat(image-viewer): support closeOnEscKeydown (#2890)

* feat(Upload): add Some Features and Bugs (#2891)

* feat: rebase develo

* feat(upload): some features

* test: update snapshots

* fix: remove unsued code

* feat(select): props collapsedItems to add onClose function (#2863)

* fix: 修正 lodash 引入 (#2893)

* fix(slider): step < 1 is not working (#2894)

* fix(slider): fix step is not working

* chore: update common

* chore: update demo

* fix(checkbox): value.splice does not work (#2896)

* feat(checkbox): support Array.splice

* revert: demo

* chore: release 1.7.2 (#2895)

* chore: release 1.7.2

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: fix api docs (#2904)

* chore: fix api docs

* chore: fix api docs

* fix: 误判断删除键(backspace)是空格键(space) (#2905)

* docs(Input): value type remove Number

* fix: 删除键(backspace)触发误判断成空格(space)

* fix(popup): ignore mouseenter when destroyOnClose is true and is leaving (#2898)

* feat(loading): support v-loading unbind (#2902)

* fix(table): do not calculate th width if props.showHeader=false (#2909)

* feat(space): compatibility problems (#2887)

* fix(space): compatibility problems

* test: unit tests

* feat: update common and snapshots

* test: update common and unit tests

* test: update snapshots

* chore: add ignore async expamle list test

* fix(checkbox): unexpected behavior when disabled is handled (#2911)

* fix(checkbox): unexpected behavior when disabled is handled

* fix(checkbox): max disabled state

---------

Co-authored-by: chaishi <974383157@qq.com>

* feat(table): support update edited cell value (#2917)

* [Checkbox] fix set value checked before options pushed, while checkbox UI is not checked (#2914)

* fix: useElementLazyRender default value

* fix(checkbox): set value before options change does not work

* fix: useElementLazyRender

* [Table] fix column resize problem; column controller of multiple header improvement (#2916)

* docs: demo inprovement

* fix(table): multi header column config

* fix: 修复列宽调整问题

* fix(table): column controller of multiple header does not work

* test: update snapshots

* test: update snapshots

* feat(input): support number type (#2906)

* feat(input): support number type

* feat(input): default type is string

* fix: add ts

* feat: inputvalue string

* fix: lint error

* feat(taginput): support prefixIcon

* chore: remove api not implemented

---------

Co-authored-by: wū yāng <uyarnchen@gmail.com>

* feat(statistic): add Statistic component  (#2397)

* Merge branch 'docs/statistic' into feat/statistic

* feat(statistic): add new component for statistic

add new component for statistic

BREAKING CHANGE: add statistic

* perf(renamed icons for consistency): renamed icons for consistency

Renamed icons for consistency

* feat(statistic): add component tests and update examples

add component tests and update examples

* chore(submodules): submodules

* docs(statistic): add file description

* chore: update snapshot

* chore: fix ui feedback

* chore: update snapshot

* chore: update common

* chore: update common

---------

Co-authored-by: Uyarn <uyarnchen@gmail.com>

* fix(Textarea): autosize nextTick null err (#2921)

* feat(table): lazyLoad works not properly (#2915)

* fix: useElementLazyRender

* test: update snapshots

---------

Co-authored-by: Uyarn <uyarnchen@gmail.com>

* chore: update docs (#2923)

* chore: update docs

* chore: update docs

* chore: update CONTRIBUTING.md

* fix(cascader): fix placeholder warning (#2924)

* chore: release 1.8.0 (#2925)

* chore: release 1.8.0

* chore: remove deprecated CHANGELOG

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: release 1.8.0-naruto

---------

Co-authored-by: TabSpace <pillar0514@163.com>
Co-authored-by: lxc-orange <108909689+lxc-orange@users.noreply.github.com>
Co-authored-by: sheepluo <yaoyanhuoyi@qq.com>
Co-authored-by: bloglab <37498563+ubloglab@users.noreply.github.com>
Co-authored-by: fennghuang <89014758+fennghuang@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: liweijie0812 <674416404@qq.com>
Co-authored-by: Guxi11 <zhang.yuanyuan@pku.edu.cn>
Co-authored-by: Zz-ZzzZ <48228016+Zz-ZzzZ@users.noreply.github.com>
Co-authored-by: betavs <34408516+betavs@users.noreply.github.com>
Co-authored-by: chaishi <974383157@qq.com>
Co-authored-by: 李江辰 <SpaceCode@foxmail.com>
Co-authored-by: Nined <nined@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants