Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Upload】 fix: 修复handleProgress file状态判断 #640

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

brianzhang
Copy link
Contributor

@brianzhang brianzhang commented Mar 25, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复

🔗 相关 Issue

innerFiles.forEach((file) => {
  file.percent = Math.min(percent, 100);
  this.loadingFile = file.status === 'success' ? null : file;
});

💡 需求背景和解决方案

添加文件status状态判断

📝 更新日志

  • fix(upload): 处理 success 事件先于 progress 事件触发时,上传文件 loadingFile 值不正确的场景

  • fix(upload): 处理最大数量限制 max 在多次文件选择中判断不正确问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@chaishi
Copy link
Collaborator

chaishi commented Mar 25, 2022

Breaking Change 代码,需要慎重

辛苦仔细说明此次变更的原因

修复handleProgress handleSuccess同时触发回调,导致loadingFile为正常清空

BREAKING CHANGE: 修复handleProgress handleSuccess同时触发回调,导致loadingFile为正常清空
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

完成

@chaishi chaishi merged commit 78f3e97 into Tencent:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants