Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dialog alert ts error #796

Merged
merged 1 commit into from Apr 24, 2022
Merged

fix: dialog alert ts error #796

merged 1 commit into from Apr 24, 2022

Conversation

PengYYYYY
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(dialog): 修复 alert 类型错误

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 633 kB

ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 42.8 kB
./dist/tdesign.js 351 kB
./dist/tdesign.min.css 38.1 kB
./dist/tdesign.min.js 202 kB

@codecov-commenter
Copy link

Codecov Report

Merging #796 (f9c8218) into develop (a0db0df) will increase coverage by 4.04%.
The diff coverage is 66.79%.

@@             Coverage Diff             @@
##           develop     #796      +/-   ##
===========================================
+ Coverage    57.56%   61.60%   +4.04%     
===========================================
  Files          346      354       +8     
  Lines        12828    13260     +432     
  Branches      2405     2500      +95     
===========================================
+ Hits          7384     8169     +785     
+ Misses        5200     4837     -363     
- Partials       244      254      +10     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/hooks/useVirtualScroll.ts 24.51% <ø> (ø)
src/input/index.ts 100.00% <ø> (ø)
src/menu/menu.tsx 61.90% <ø> (ø)
src/select/option.tsx 16.66% <ø> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bedd2...f9c8218. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@uyarn uyarn merged commit fab77c0 into develop Apr 24, 2022
@uyarn uyarn deleted the fix/dialog/tserror branch April 24, 2022 03:07
@github-actions github-actions bot mentioned this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants