fix drawer scroll through #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaishi
reviewed
Dec 26, 2021
src/drawer/drawer.tsx
Outdated
| @@ -73,6 +77,9 @@ export default mixins(ActionMixin, getConfigReceiverMixins<Vue, DrawerConfig>('d | |||
| justifyContent: this.placement === 'right' ? 'flex-start' : 'flex-end', | |||
| }; | |||
| }, | |||
| lockFullscreen(): boolean { | |||
| return this.preventScrollThrough; | |||
| }, | |||
There was a problem hiding this comment.
preventScrollThrough 已经是独立的 boolean 变量，不需要再定义 lockFullscreen 了
src/drawer/drawer.tsx
Outdated
| import { ClassName, Styles } from '../common'; | ||
| import ActionMixin from '../dialog/actions'; | ||
|
|
||
| type FooterButtonType = 'confirm' | 'cancel'; | ||
|
|
||
| const name = `${prefix}-drawer`; | ||
| const lockClass = `${prefix}-drawer-lock`; |
There was a problem hiding this comment.
t-drawer-lock更名为t-drawer--lock- 同步修改
t-loading-lock为t-loading--lock t-dialog--lock（Dialog 也使用同样的方式处理滚动穿透）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sub modules pr address: Tencent/tdesign-common#59
其中涉及到了src/drawer/props.ts、src/drawer/type.ts这两个文件的变更: 增加preventScrollThrough属性