Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify test file description specification #2669

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leepcode
Copy link
Contributor

The specification of test file description is unified

@coveralls
Copy link

coveralls commented Jul 29, 2020

Coverage Status

Coverage increased (+0.01%) to 34.818% when pulling 61af4f9 on leepcode:2.0.x into 29e16ed on Tencent:master.

@@ -1,7 +1,7 @@
const expect = require('chai').expect;
const FileDep = require('../../core/fileDep');

describe('FileDep', function() {
describe('cli core FileDep', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议 describe 使用文件名吧。

@@ -23,7 +23,7 @@ describe('parseOptions', function() {
});
});

it('parse', function() {
it('should parse', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些地方的,英文不符合逻辑吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants