Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: 特性开关功能,删除业务灰度白名单不生效 #1835

Closed
wangyu096 opened this issue Mar 13, 2023 · 1 comment
Closed

bugfix: 特性开关功能,删除业务灰度白名单不生效 #1835

wangyu096 opened this issue Mar 13, 2023 · 1 comment
Assignees
Labels
done 已上线到正式环境并验收通过 kind/bug 程序故障Bug,漏洞

Comments

@wangyu096
Copy link
Collaborator

wangyu096 commented Mar 13, 2023

Version / Branch / tag

3.7.1

出了什么问题?(What Happened?)

特性开关功能,删除业务灰度白名单不生效

原始配置:

job
  features:
    gseV2:
      enabled: true
      strategy:
        id: "ResourceScopeWhiteListToggleStrategy"
        params:
          resourceScopeList: "biz:2,biz:41"

修改为如下配置,去掉biz:41这个灰度业务

job
  features:
    gseV2:
      enabled: true
      strategy:
        id: "ResourceScopeWhiteListToggleStrategy"
        params:
          resourceScopeList: "biz:2"

执行/actuator/busrefresh 刷新配置之后,业务ID=41这个业务仍然是使用了GSEV2版本,与预期不符

如何复现?(How to reproduce?)

多次更新特性开关配置,新的配置不生效

预期结果(What you expect?)

@wangyu096 wangyu096 added the kind/bug 程序故障Bug,漏洞 label Mar 13, 2023
@wangyu096 wangyu096 self-assigned this Mar 13, 2023
@wangyu096 wangyu096 changed the title bugfix: 特性开关功能存在多线程安全问题 bugfix: 特性开关功能,删除业务灰度白名单不生效 Mar 13, 2023
@wangyu096
Copy link
Collaborator Author

问题原因:
image
使用了静态变量,即使重新初始化Strategy,仍然是原来的变量值

jsonwan added a commit that referenced this issue Mar 14, 2023
bugfix: 特性开关功能,删除业务灰度白名单不生效 #1835
@bkjob-bot bkjob-bot added the done 已上线到正式环境并验收通过 label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done 已上线到正式环境并验收通过 kind/bug 程序故障Bug,漏洞
Projects
None yet
Development

No branches or pull requests

2 participants