Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 主机AgentId更新后，小概率出现使用旧AgentId下发任务 #2142 #2184

Merged
merged 1 commit into from Jul 4, 2023
Merged

fix: 主机AgentId更新后，小概率出现使用旧AgentId下发任务 #2142 #2184

merged 1 commit into from Jul 4, 2023

Conversation

jsonwan
Copy link
Collaborator

@jsonwan jsonwan commented Jul 4, 2023 •
edited

  1. 批量查询主机拓扑关系，提升接口性能；
  2. 修复trace数据上报。

@jsonwan jsonwan force-pushed the github_fix/sync branch 2 times, most recently from f60226f to 471fe38 Compare July 4, 2023 10:13
wangyu096
wangyu096 requested changes Jul 4, 2023
View reviewed changes
...age/service-job-manage/src/main/java/com/tencent/bk/job/manage/dao/impl/HostTopoDAOImpl.java Outdated
defaultTable.MODULE_ID
).from(defaultTable)
.where(defaultTable.HOST_ID.in(
hostIds.stream()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的主机是指业务下的全部主机，某些业务可能存在几万个主机，如果使用 in 查询的话，会不会有性能问题？可以验证下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已验证，无性能问题

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改为按业务ID查询

@jsonwan
fix: 主机AgentId更新后，小概率出现使用旧AgentId下发任务 TencentBlueKing#2142
343d7c7 
1. 批量查询主机拓扑关系，提升接口性能；
2. 修复trace数据上报。
@wangyu096 wangyu096 merged commit ad8b27d into TencentBlueKing:master Jul 4, 2023
4 checks passed
@jsonwan jsonwan deleted the github_fix/sync branch July 7, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyu096 wangyu096 wangyu096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsonwan @wangyu096