Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 订阅支持业务集 (closed #1724) #1912

Open
wants to merge 4 commits into
base: v2.4.4-dev
Choose a base branch
from

Conversation

CohleRustW
Copy link
Collaborator

@CohleRustW CohleRustW commented Nov 2, 2023

PR

CheckList(PR Assigners)

确认已完成以下操作:

  • 已将分支与当前合入分支同步
  • 已在关联 Issue 中补充「功能自测」部分内容
  • 已更新关联 Issue 的状态 backlog -> todo -> for test -> tested(需通过测试同学测试) -> done
  • 将 PR 添加上 pr/reviewable

CheckList(PR Reviewers)

确认已完成以下操作:

  • 检查关联 Issue 「功能自测」部分内容
  • 必要时打回 pr/reviewable,要求重新修改
  • 及时 Approve

@CohleRustW CohleRustW added the pr/reviewable 可被 review 的 PR label Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Merging #1912 (a49cd53) into v2.4.4-dev (322d00e) will increase coverage by 0.65%.
Report is 2 commits behind head on v2.4.4-dev.
The diff coverage is 93.57%.

@@              Coverage Diff               @@
##           v2.4.4-dev    #1912      +/-   ##
==============================================
+ Coverage       74.58%   75.24%   +0.65%     
==============================================
  Files             403      403              
  Lines           27758    27844      +86     
==============================================
+ Hits            20703    20950     +247     
+ Misses           7055     6894     -161     
Files Coverage Δ
apps/backend/constants.py 98.07% <100.00%> (+0.03%) ⬆️
apps/backend/subscription/commons.py 95.16% <100.00%> (+14.83%) ⬆️
apps/backend/subscription/errors.py 100.00% <100.00%> (ø)
apps/backend/subscription/serializers.py 91.61% <100.00%> (ø)
apps/backend/subscription/tasks.py 71.93% <100.00%> (+2.13%) ⬆️
apps/node_man/models.py 78.40% <100.00%> (+0.95%) ⬆️
apps/node_man/serializers/base.py 79.56% <100.00%> (+21.99%) ⬆️
apps/backend/subscription/tools.py 64.01% <96.87%> (+5.56%) ⬆️
apps/backend/subscription/views.py 52.72% <75.00%> (+1.47%) ⬆️
apps/node_man/handlers/cmdb.py 74.14% <90.00%> (+0.52%) ⬆️
... and 1 more

... and 12 files with indirect coverage changes

@CohleRustW

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/reviewable 可被 review 的 PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants