Feature remote import #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.update_or_create( | ||
| name=config['name'], | ||
| from_config=True, | ||
| defaults=defaults) |
There was a problem hiding this comment.
name是唯一键，如果存在 from_config=False 的数据，这句话会报错，建议把 from_config=True 放到 defaults 中
Codecov Report
@@ Coverage Diff @@
## feature_remote_component_load #114 +/- ##
================================================================
+ Coverage 61.85% 62.65% +0.8%
================================================================
Files 306 320 +14
Lines 12641 12990 +349
================================================================
+ Hits 7819 8139 +320
- Misses 4822 4851 +29
Continue to review full report at Codecov.
|
pagezz-canway
pushed a commit
to pagezz-canway/bk-sops
that referenced
this pull request
Dec 27, 2019
* feature: 添加非标准存储代码导入器及 git 仓库代码导入器 * feature: 添加远程包源模型 * feature: 添加加载远程模块相关逻辑代码 * minor: 添加加载远程插件 APP * feature: pipeline.utils.importer 添加导入器上下文 * minors: 完善 external_plugins app 的单元测试 * feature: GitRepoImporter 添加强制 HTTPS 开关 * minor: 添加远程包源配置获取语句 * minor: 单元测试完善，Importer Logger 配置修改，GitImporter 支持配置代理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #113
close #112
close #111
close #110
close #126