Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature remote import #158

Conversation

homholueng
Copy link
Contributor

  • 新功能
    • S3 模块导入器
    • 本地文件系统模块导入器
  • bug fix
    • 修复从 ComponentLibray 获取组件实例时没有处理组件可能不存在的问题

close #156
close #157
close #155

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #158 into feature_remote_component_load will increase coverage by <.01%.
The diff coverage is 64.09%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature_remote_component_load     #158      +/-   ##
=================================================================
+ Coverage                          62.65%   62.65%   +<.01%     
=================================================================
  Files                                320      323       +3     
  Lines                              12990    13191     +201     
=================================================================
+ Hits                                8139     8265     +126     
- Misses                              4851     4926      +75
Impacted Files Coverage Δ
gcloud/webservice3/resources.py 39.75% <0%> (-0.33%) ⬇️
pipeline/engine/core/runtime.py 95.23% <100%> (+0.07%) ⬆️
...ontrib/external_plugins/utils/importer/__init__.py 100% <100%> (ø) ⬆️
pipeline/component_framework/library.py 100% <100%> (ø) ⬆️
pipeline/engine/api.py 96.35% <100%> (+0.05%) ⬆️
pipeline/engine/utils.py 95.45% <100%> (+4.54%) ⬆️
pipeline/contrib/external_plugins/models/base.py 96.92% <100%> (+0.14%) ⬆️
pipeline/engine/core/schedule.py 98.01% <100%> (+0.08%) ⬆️
pipeline/component_framework/component.py 96.29% <100%> (+0.29%) ⬆️
pipeline/component_framework/test.py 27.27% <27.27%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34ce41...8ef0134. Read the comment docs.

@@ -74,8 +74,8 @@ def run_loop(process):
return

# try to transit current node to running state
action = Status.objects.transit(id=current_node.id, to_state=states.RUNNING, start=True,
name=str(current_node.__class__))
name = (current_node.name or str(current_node.__class__))[:64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64 改成常量

@pagezz-canway pagezz-canway merged commit b088490 into TencentBlueKing:feature_remote_component_load Apr 17, 2019
pagezz-canway pushed a commit to pagezz-canway/bk-sops that referenced this pull request Dec 27, 2019
* improvement: 优化从配置中创建包源和与 API 创建的包源包名冲突时的提示

* feature: 添加 S3 及 FileSystem importer

* minor: 添加 S3Importer 及 FSImporter 的单元测试

* feature: s3 与 fs 类型的 ExternalSource 返回对应的 importer

* feature: 允许用户通过配置控制每个源的安全限制

* bugfix: 修复获取组件实例时没有处理组件可能不存在的问题

* feature: 添加 form_is_embbeded 方法来判断组件是否包含嵌入式的表单

* feature: component 相关接口添加 form_is_embedded 字段

* minor: sync pipeline code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants