Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(dialog): transfer 属性失效 #1673

Closed
forrany opened this issue Apr 4, 2024 · 1 comment
Closed

bugfix(dialog): transfer 属性失效 #1673

forrany opened this issue Apr 4, 2024 · 1 comment
Assignees
@xintaoLi
Labels
bug Something isn't working

Comments

@forrany
Copy link
Contributor

forrany commented Apr 4, 2024

Version / Branch / tag

出了什么问题？(What Happened?)
在 #1567 中，trsanfer属性的修改被修改错误，导致原逻辑受到影响。

在最初逻辑中，trasnfer 支持boolean | string | HtmlElement

其中 如果是 boolean:
ture: 表示移动到 body 下
false: 表示保持原结构

string 支持 parent

image

新的修改导致上面的逻辑失效

image

如何复现？(How to reproduce?)

预期结果(What you expect?)
@forrany forrany added the bug Something isn't working label Apr 4, 2024
@ielgnaw ielgnaw assigned xintaoLi and unassigned ielgnaw Apr 11, 2024
@lhzzforever lhzzforever mentioned this issue Sep 3, 2024
Merged
@ielgnaw
Copy link
Collaborator

ielgnaw commented Sep 5, 2024

bkui-vue@2.0.1-beta.64

@ielgnaw ielgnaw closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xintaoLi xintaoLi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ielgnaw @xintaoLi @forrany