Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make snapshot" target for building packages from develop branch #209

Closed
dahorak opened this issue Jun 16, 2017 · 6 comments
Closed

"make snapshot" target for building packages from develop branch #209

dahorak opened this issue Jun 16, 2017 · 6 comments
Assignees

Comments

@dahorak
Copy link
Contributor

dahorak commented Jun 16, 2017

make snapshot target is not implemented and because of that the build trigger jobs are failing:
https://ci.centos.org/view/tendrl-build/job/tendrl-build-1-develop-api/

It would be good if it will be possible to build snapshot version package (usable mainly for packages from develop and prospectively from feature branches).

@TimothyAsir
Copy link
Contributor

Why don't you update the version with current date and time and use make rpm.
Why you want to use make snapshot which will give you a random version number.

@mbukatov
Copy link
Contributor

mbukatov commented Jul 4, 2017

The point here is to achieve unification of the build process for all tendrl packages, so that we can move on and build ci jobs on top of that, as has been agreed on. As far as I know, only dashboard and api packages out of all tendrl packages doesn't implement this.

@TimothyAsir
Copy link
Contributor

Agree!, Are you ok with the release version format to %m_%d_%Y_%H_%M_%S.
So that the existing packages in the repo will not get disturbed.
Currently we are using the release format as "%m_%d_%Y_%H_%M_%S only for our builds.

TimothyAsirJeyasing added a commit to TimothyAsirJeyasing/tendrl-api that referenced this issue Jul 4, 2017
tendrl-bug-id: Tendrl#209

Signed-off-by: Timothy Asir J <tjeyasin@redhat.com>
@dahorak
Copy link
Contributor Author

dahorak commented Jul 11, 2017

Agree!, Are you ok with the release version format to %m_%d_%Y_%H_%M_%S.
So that the existing packages in the repo will not get disturbed.
Currently we are using the release format as "%m_%d_%Y_%H_%M_%S only for our builds.

I have two points related to the version format:

  1. I think the order "Month, Day, Year.." is not the best one, as it is not properly sortable. Better way would be Year, Month, Day... ("%Y_%m_%d_%H_%M_%S").
  2. make snapshot in other Tendrl packages create version based on git revision hash, which is good, because without that, it is hardly possible to link the particular build with particular source code revision.

Also please check the Package Versioning on Fedora Wiki - mainly the Snapshots section. I think that is the best format for package versioning (as it was mentioned also here usmqe/usmqe-centos-ci#1 (comment)).

Just side note: as git hash is "pseudo random" string, it is not properly sortable, so it will not be possible to distinguish older and newer packages. One solution is to add full timestamp (as described above) before the hash, second solution is to prepended the hash by the number of commits from the last marked version (similarly as what git describe do).

TimothyAsirJeyasing added a commit to TimothyAsirJeyasing/tendrl-api that referenced this issue Jul 27, 2017
tendrl-bug-id: Tendrl#209
Signed-off-by: Timothy Asir J <tjeyasin@redhat.com>
@TimothyAsirJeyasing
Copy link
Contributor

@mbukatov
Copy link
Contributor

mbukatov commented Aug 4, 2017

This issue can be closed.

@r0h4n r0h4n closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants