Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis job should check git commit message for github bug id and an optional tendrl spec name #66

Closed
r0h4n opened this issue Nov 28, 2016 · 4 comments
Milestone

Comments

@r0h4n
Copy link
Contributor

r0h4n commented Nov 28, 2016

Moving on, all git commits should contain mandatory mention on newline of
"tendrl-bug-id: <tendrl_repo>/<github-issue-id>" and optional mention of "tendrl-spec: <tendrl_spec_name>" in the commit msg.

eg:
"""
Packaging python-etcd

Added Makefile and spec file to create python-etcd package
Now one can use "make rpm" to pull the latest source from github
and build the source rpm
and using the Makefile one can also build rpm using "make rpm"
which will use mock to build the rpm using srpm.

tendrl-bug-id: #18

tendrl-spec: refactor_gluster_integration_get_state_dump
"""

@r0h4n
Copy link
Contributor Author

r0h4n commented Nov 28, 2016

Fixed: af0c643

@r0h4n r0h4n closed this as completed Nov 28, 2016
@r0h4n
Copy link
Contributor Author

r0h4n commented Nov 28, 2016

@brainfunked @nthomas-redhat @TimothyAsir @shtripat @GowthamShanmugam @nnDarshan @anivargi @anmolbabu Please take note.and make appropriate changes to your repos

@nnDarshan
Copy link
Contributor

@r0h4n adding a "#" before the issue number will automatically hyperlink the issue to the commit message. Is it better to have something like:
"tendrl-bug-id: <tendrl_repo>/#"

or just / will take care of it ?

@r0h4n
Copy link
Contributor Author

r0h4n commented Nov 29, 2016

@nnDarshan Thanks for suggesting, making that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants