Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messages for tasks/jobs #834

Closed
julienlim opened this issue Feb 26, 2018 · 3 comments
Closed

Improve messages for tasks/jobs #834

julienlim opened this issue Feb 26, 2018 · 3 comments
Assignees

Comments

@julienlim
Copy link
Member

julienlim commented Feb 26, 2018

Problem Description

  • Messages are too verbose
  • Task messages (in UI) are several lines and pages long
  • Some of the task messages should be Debug (vs. Info), and there ought to be a way to suppress debug vs. non-debug information
  • Every config parameter does not need to be expressed in the Task Details as we’re trying to convey what task is performed

Recommendations

  • Acquiring and releasing of locks should be "debug" tasks
  • Filter Task Details table (in UI) to show all rows except “debug” (and add ability to show “debug” or verbose mode)
  • For the “Starting configuration of … on with ...” messages (which seems related to the collectd plugin), it may make sense to make all those entries “debug” and have a single line entry (before they kick off) that says “Configuring collectd monitoring on ” with an “info” type.

Current Message:

Starting configuration of tendrl_gluster on ci-usm3-gl6.usmqe.lab.eng.brq.redhat.com with {"integration_id": "44f8f6f3-a103-437b-a3e1-701db25c5382", "graphite_port": 2003, "logging_socket_path": "/var/run/tendrl/message.sock", "hostname": "ci-usm3-gl6.usmqe.lab.eng.brq.redhat.com", "etcd_ca_cert_file": "/etc/pki/tls/certs/ca-usmqe.crt", "etcd_host": "ci-usm3-server.usmqe.lab.eng.brq.redhat.com", "interval": 60, "node_id": "7c192ea1-429a-4dbe-b70a-61706f1aec78", "graphite_host": "ci-usm3-server.usmqe.lab.eng.brq.redhat.com", "etcd_port": 2379, "interface": "ens3", "etcd_cert_file": "/etc/pki/tls/certs/etcd.crt", "is_provisioner_node": true, "etcd_key_file": "/etc/pki/tls/private/etcd.key"}as conf parameters

Recommendation for Message:

Configuring <service_name> monitoring on <object>

E.g. Configuring tendrl_gluster on ci-usm3-gl6.usmqe.lab.eng.brq.redhat.com

A more comprehensive list of recommendations can be found at Tendrl Log Messaging Recommendations.

@r0h4n @nthomas-redhat @shtripat @Tendrl/qe @jjkabrown1 @mcarrano @gnehapk @shtripat @a2batic

@nthomas-redhat
Copy link
Contributor

@julienlim , Are you working on this? Based on our last conversation you wanted to pick this up

@julienlim
Copy link
Member Author

@nthomas-redhat I'm not able to at the moment as I have some other higher priority tasks I have to take care of. Apologies.

@r0h4n
Copy link
Contributor

r0h4n commented Mar 21, 2018

@nthomas-redhat any updates on this?

nthomas-redhat added a commit to nthomas-redhat/commons that referenced this issue Apr 7, 2018
Signed-off-by: Nishanth Thomas <nthomas@redhat.com>
nthomas-redhat added a commit to nthomas-redhat/commons that referenced this issue Apr 7, 2018
Signed-off-by: Nishanth Thomas <nthomas@redhat.com>
nthomas-redhat added a commit to nthomas-redhat/commons that referenced this issue Apr 13, 2018
Signed-off-by: Nishanth Thomas <nthomas@redhat.com>
@r0h4n r0h4n added this to the Milestone 5 (2018) milestone Apr 19, 2018
@r0h4n r0h4n closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants