Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues related to etcd_server parameter #109

Closed
wants to merge 1 commit into from
Closed

Fixed issues related to etcd_server parameter #109

wants to merge 1 commit into from

Conversation

shtripat
Copy link
Member

@shtripat shtripat commented Jan 16, 2017 •
edited

tendrl-bug-id: #114

Signed-off-by: Shubhendu shtripat@redhat.com

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.629% when pulling f19c9f7 on shtripat:config-changes into 805e11a on Tendrl:master.

@shtripat shtripat self-assigned this Jan 16, 2017
nnDarshan
nnDarshan reviewed Jan 17, 2017
View reviewed changes
Copy link
Contributor

@nnDarshan nnDarshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.668% when pulling 990e11d on shtripat:config-changes into 73f19a6 on Tendrl:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.668% when pulling c5e0156 on shtripat:config-changes into 73f19a6 on Tendrl:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.436% when pulling d6848ee on shtripat:config-changes into 3f61eee on Tendrl:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.608% when pulling 5f80eeb on shtripat:config-changes into 1f4bb6b on Tendrl:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.608% when pulling 6d398ee on shtripat:config-changes into a185b38 on Tendrl:master.

@shtripat shtripat mentioned this pull request Jan 18, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.608% when pulling 0f132bd on shtripat:config-changes into 6048e1a on Tendrl:master.

Fixed issues related to etcd_server parameter
82f1ccb 
tendrl-bug-id: Tendrl#114

Signed-off-by: Shubhendu <shtripat@redhat.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.608% when pulling 82f1ccb on shtripat:config-changes into 6048e1a on Tendrl:master.

anmolbabu
anmolbabu reviewed Jan 19, 2017
View reviewed changes
tendrl/commons/flows/base_flow.py
@@ -156,18 +156,19 @@ def extract_atom_details(self, atom_name):
namespace = atom_name.split('.objects.')[0]
object_name = atom_name.split('.objects.')[1].split('.atoms.')[0]
atoms = self.definitions[namespace]['objects'][object_name]['atoms']
atom = atoms[atom_name.split('.')[-1]]
atom = atoms[atom_name.split('.')[-2]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In https://github.com/anmolbabu/performance_monitoring/blob/bc6e351e2f268aaf1c18d770a3fcf367ad33fe2c/tendrl/performance_monitoring/manager/tendrl_definitions_performance_monitoring.py I didn't require this change as I changed my definition file itself to suit this. So in my definition file I changed the atom names under the objects to class names instead of file names because as per the split in above line it turns out to be looking for the last part of the module path which is the class name and I verified the change to be working.please suggest what is the decided/better approach so that we can make changes accordingly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with anything. The point is we are mixing uppercase and lowercase a lot for object and atom names. I personally feel we should restrict to uppercase for only object names and keep atom names lowercase only and as in above fix we are actually getting the module name for the atom details to be loaded from definitions.
@r0h4n @brainfunked @nthomas-redhat comments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check Tendrl/node-agent#147 for final naming. The problem needs to be tackled at both the source code side and the Definitions side.

The above PR will clear the confusion, keep an eye

@shtripat shtripat mentioned this pull request Jan 20, 2017
Closed
@r0h4n
Copy link
Contributor

r0h4n commented Jan 22, 2017

PR not relevant any more

@r0h4n r0h4n closed this Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolbabu anmolbabu anmolbabu approved these changes

@nnDarshan nnDarshan nnDarshan left review comments

@r0h4n r0h4n Awaiting requested review from r0h4n

@nthomas-redhat nthomas-redhat Awaiting requested review from nthomas-redhat

Assignees

@shtripat shtripat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shtripat @coveralls @r0h4n @anmolbabu @nnDarshan