Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Job acceptor to pick jobs based on tags. #117

Closed
wants to merge 1 commit into from

Conversation

nnDarshan
Copy link
Contributor

This patch modifies job acceptor to pick jobs only
if the tags in "targeted_tags" field of job matches
with the node-agent tags.

tendrl-bug-id: #116
Signed-off-by: nnDarshan darshan.n.2024@gmail.com

This patch modifies job acceptor to pick jobs only
if the tags in "targeted_tags" field of job matches
with the node-agent tags.

tendrl-bug-id: Tendrl#116
Signed-off-by: nnDarshan <darshan.n.2024@gmail.com>
@nnDarshan
Copy link
Contributor Author

@shtripat @nthomas-redhat @r0h4n Please review

@nnDarshan
Copy link
Contributor Author

related to: Tendrl/specifications#44

Copy link
Member

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 59.375% when pulling 9f86361 on nnDarshan:FixAcceptorForTags into 1f4bb6b on Tendrl:master.

@nnDarshan
Copy link
Contributor Author

patch for Tendrl/specifications#44

@r0h4n
Copy link
Contributor

r0h4n commented Feb 1, 2017

This one still required?

@nnDarshan
Copy link
Contributor Author

Its needed, But I will have to verify it again with latest master. Please mark it as Changes needed. Will try to close this soon

@r0h4n r0h4n closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants