Fix flow extraction failure #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r0h4n @shtripat @nthomas-redhat Please review |
shtripat
reviewed
Jan 10, 2017
| try: | ||
| namespace = flow_name.split(".flows.")[0] | ||
| flow = definitions[namespace]['flows'][flow_name.split(".")[-1]] | ||
| except KeyError: |
There was a problem hiding this comment.
Add some comments to explain the logic a bit.
There was a problem hiding this comment.
Yes, this needs an example as a commentm rest LGTM
r0h4n
suggested changes
Jan 11, 2017
| try: | ||
| namespace = flow_name.split(".flows.")[0] | ||
| flow = definitions[namespace]['flows'][flow_name.split(".")[-1]] | ||
| except KeyError: |
There was a problem hiding this comment.
Yes, this needs an example as a commentm rest LGTM
tendrl-spec: segragate_object_specific_flows tendrl-bug-id: Tendrl#94 Signed-off-by: root <root@dhcp42-195.lab.eng.blr.redhat.com>
nnDarshan
force-pushed
the
FixFlowExtractionIssue
branch
from
841eee6
to
10ea9e8
Compare
r0h4n
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tendrl-spec: segragate_object_specific_flows
tendrl-bug-id: #94
Signed-off-by: root root@dhcp42-195.lab.eng.blr.redhat.com