Multiple peer connected events when new peer probe is done in managed cluster #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cluster When new peer probe is done then all nodes raises peer connected info event, so multiple events are displayed in UI. As per logic in Tendrl/node-agent#817 first non-info alert raised then it will start compare with old alert to avoid duplicate events but here actaully info alert is raised first, so node-agent handlert does not have any old alert to avoid duplicate. And also we have a check to avoid first info alert but it is wrong None == "" won't match. I have corrected the logic here. bugzilla: 1579937 tendrl-bug-id: Tendrl#648 Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
| @@ -157,7 +157,7 @@ def run(self): | |||
| current_status = peers[ | |||
| 'peer%s.connected' % index | |||
| ] | |||
| if stored_peer_status != "" and \ | |||
| if stored_peer_status and \ | |||
There was a problem hiding this comment.
None == "" won't match
|
@shtripat @r0h4n @nthomas-redhat please review |
r0h4n
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new peer probe is done then all nodes raises peer connected info
event, so multiple events are displayed in UI. As per logic in
Tendrl/node-agent#817 first non-info alert
raised then it will start comparing with an old alert to avoid duplicate
events but here actually info alert is raised first, so node-agent handler
does not have any old alert to avoid duplicate. And also we have a check to
avoid first info alert but it is wrong None == "" won't match.
I have corrected the logic here.
bugzilla: 1579937
tendrl-bug-id: #648
Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com