Added ttl for node status. #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r0h4n @shtripat @anivargi @nthomas-redhat Please review |
|
NOTE: This patch is dependent on: Tendrl/commons#738. So please merge this only after merging above patch |
nnDarshan
force-pushed
the
update_node_heartbeat
branch
from
a991a36
to
7d89c11
Compare
nnDarshan
changed the title
r0h4n
suggested changes
Sep 19, 2017
| @@ -29,12 +29,12 @@ def _run(self): | |||
| current_tags += ["tendrl/node_%s" % NS.node_context.node_id] | |||
| NS.node_context.tags = list(set(current_tags)) | |||
| NS.node_context.save() | |||
|
|
|||
| SYNC_TTL = int(NS.config.data.get("sync_interval", 10)) + 250 | |||
There was a problem hiding this comment.
I would suggest you add 100 instead of 250
Also, SYNC_TTL should be _sync_ttl
nnDarshan
force-pushed
the
update_node_heartbeat
branch
from
7d89c11
to
7370542
Compare
r0h4n
suggested changes
Sep 21, 2017
|
|
||
| sync_disks_thread = gevent.spawn(disk_sync.sync) | ||
| sync_disks_thread.join() | ||
|
|
||
| sync_networks_thread = gevent.spawn(network_sync.sync) | ||
| sync_networks_thread.join() | ||
|
|
||
| if "tendrl/monitor" in NS.node_context.tags: | ||
| update_node_status_thread = gevent.spawn( | ||
| node_status_update.update) |
There was a problem hiding this comment.
instead of node_status_update.update
call it "check_all_managed_nodes_status.run()"
| NS._int.client.read( | ||
| "/nodes/{0}/NodeContext/status".format(node_id) | ||
| ) | ||
| except etcd.EtcdKeyNotFound: |
There was a problem hiding this comment.
This read and then write is not atomic
use
instead of reading and then writing, catch etcd.EtcdAlreadyExist
This patch adds ttl fol node status . If the node goes down due to any reason, the status attribute will vanish after some time. Thus API layer can get to know that node is down and mark it accordingly. tendrl-bug-id: Tendrl#592 Signed-off-by: nnDarshan <darshan.n.2024@gmail.com>
nnDarshan
force-pushed
the
update_node_heartbeat
branch
from
7370542
to
f484bac
Compare
r0h4n
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds heartbeat updation during node sync.
If the node goes down due to any reason, the heart
beat object will vanish after some time. Thus API
layer can get to know that node is down and mark it
accordingly.
tendrl-bug-id: #592
Signed-off-by: nnDarshan darshan.n.2024@gmail.com