Fixing issue with multiple interface of brick and peer probe #815
Conversation
|
@r0h4n @shtripat @nthomas-redhat please review |
| ip = socket.gethostbyname(brick_host) | ||
| node_id = etcd_client.read("indexes/ip/%s" % ip).value | ||
| _key = "/nodes/%s/NodeContext/fqdn" % node_id | ||
| fqdn = etcd_client.read(_key).value |
There was a problem hiding this comment.
before reading fqdn
ensure "node_id" is present at ""indexes/tags/tendrl/integration/:integration_id" ,
otherwise there can be clash between IP address in multi cluster scenario
| brick_ip = socket.gethostbyname(brick_hostname) | ||
| else: | ||
| brick_ip = socket.gethostbyname(brick['hostname']) | ||
| brick_hostname = brick['hostname'] |
There was a problem hiding this comment.
what is the purpose of L#553? , you are simply assigning new value to `brick_ip", the why the if/else above
| brick_ip = socket.gethostbyname( | ||
| brick.get('hostname') | ||
| ) | ||
| brick_hostname = brick.get('hostname') |
There was a problem hiding this comment.
This code snippet seems similar to the one I have commented below, can you please check if both are the same and make a common util or something if they are doing the same thing
| brick_hostname = tendrl_glusterfs_utils.find_brick_host( | ||
| self.etcd_client, brick['hostname'] | ||
| ) | ||
| if brick_hostname: |
There was a problem hiding this comment.
again, this piece of code seems common, please dont duplicate this everywhere use single function
| def __init__(self): | ||
| self.provisioner_only_plugin = False | ||
| TendrlGlusterfsMonitoringBase.__init__(self) | ||
| if not self.etcd_client: | ||
| _etcd_args = dict( | ||
| host=self.CONFIG['etcd_host'], |
There was a problem hiding this comment.
does the plugin config template have these etcd_* variables?
There was a problem hiding this comment.
yes, it has, i verified
tendrl-bug-id: Tendrl#814 bugzilla: 1573075 Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
brick_multi_interface
branch
from
4843d8f
to
daccbf2
Compare
|
bz#bug-id 1573075 does not have all the required acks. So I am using bug-id 1564510 for downstream |
tendrl-bug-id: #814
bugzilla: 1573075, 1564510
Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com