New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specification for pool list view #83
Conversation
Required Input from Anup - | ||
|
||
* To add the response format for the API call | ||
* To add the polling API call and its response format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anivargi Please provide the necessary inputs here.
|
||
==== Notifications/Monitoring impact: | ||
|
||
Required Input from Anmol: To add the response format for monitoring data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anmolbabu Please provide the necessary inputs here.
Addresses #75. |
1 similar comment
Addresses #75. |
* Pool Name | ||
* Status | ||
* Cluster Name | ||
* CPU Utilisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPU utilization? or is it pool utilization?
|
||
==== Tendrl API impact: | ||
|
||
/api/1.0/GetPoolList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part lack information. state what is available currently(cluster wide list API available), what extra information reqd in the current API. Also specify the any extra APIs required(syatem wide listing?)
Which component implements sorting and filtering?
Any APis required to get the utlization data?
None | ||
|
||
== References: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer the topic issue here - #75
* For utilisation, use donut chart component. | ||
* Implement client side filer and sorting functionality. | ||
* Filter call will trigger after 1 sec the user enters the filter data. | ||
* Send polling call after 10 minutes to get the updated data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 mins might not be acceptable
* Status | ||
* Cluster Name | ||
* Pool Type | ||
* CPU Utilisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
47b0067
to
e7cae74
Compare
@cloudbehl @anivargi I have updated the PR. Please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Need to decide upon the id's and classes for BDD(Behavior-driven development). I think we can create different spec which will have common id's and classes we will be using.
* Status | ||
* Cluster Name | ||
* Pool Type | ||
* Utilisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What utilization? Storage used?
e7cae74
to
c8b0b42
Compare
@anivargi For the pool list view, below are the data that is not present in the json response of pool -
These are the data(with their mapped attribute in json) which are provided by API -
Please confirm, whether these mappings are correct or not. |
Please add usmqe/usmqe-tests#17 as testing reference. |
@anivargi @brainfunked @nthomas-redhat @anmolbabu @kamleshverma1 Please review.