Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specification for pool list view #83

Merged
merged 1 commit into from Apr 28, 2017

Conversation

gnehapk
Copy link
Member

@gnehapk gnehapk commented Dec 19, 2016

Required Input from Anup -

* To add the response format for the API call
* To add the polling API call and its response format
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anivargi Please provide the necessary inputs here.


==== Notifications/Monitoring impact:

Required Input from Anmol: To add the response format for monitoring data
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmolbabu Please provide the necessary inputs here.

@gnehapk
Copy link
Member Author

gnehapk commented Dec 19, 2016

Addresses #75.

1 similar comment
@gnehapk
Copy link
Member Author

gnehapk commented Dec 19, 2016

Addresses #75.

* Pool Name
* Status
* Cluster Name
* CPU Utilisation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU utilization? or is it pool utilization?


==== Tendrl API impact:

/api/1.0/GetPoolList
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part lack information. state what is available currently(cluster wide list API available), what extra information reqd in the current API. Also specify the any extra APIs required(syatem wide listing?)
Which component implements sorting and filtering?
Any APis required to get the utlization data?

None

== References:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer the topic issue here - #75

* For utilisation, use donut chart component.
* Implement client side filer and sorting functionality.
* Filter call will trigger after 1 sec the user enters the filter data.
* Send polling call after 10 minutes to get the updated data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 mins might not be acceptable

* Status
* Cluster Name
* Pool Type
* CPU Utilisation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@gnehapk
Copy link
Member Author

gnehapk commented Dec 20, 2016

@cloudbehl @anivargi I have updated the PR. Please review it.

Copy link
Member

@cloudbehl cloudbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Need to decide upon the id's and classes for BDD(Behavior-driven development). I think we can create different spec which will have common id's and classes we will be using.

* Status
* Cluster Name
* Pool Type
* Utilisation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What utilization? Storage used?

@gnehapk
Copy link
Member Author

gnehapk commented Dec 21, 2016

@anivargi For the pool list view, below are the data that is not present in the json response of pool -

  1. Status
  2. Type
  3. Utilisation
  4. Replicas
  5. OSDs
  6. Quotas
  7. Alerts

These are the data(with their mapped attribute in json) which are provided by API -

  1. name - pools.poolname
  2. Cluster name - maps.cluster_name
  3. PGs - pools.pg_num

Please confirm, whether these mappings are correct or not.

@mkudlej
Copy link

mkudlej commented Jan 2, 2017

Please add usmqe/usmqe-tests#17 as testing reference.

@r0h4n r0h4n merged commit fcbdcec into Tendrl:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants