Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using flexbox instead of floating grid #6

Closed
gnehapk opened this issue Sep 22, 2016 · 6 comments
Closed

Using flexbox instead of floating grid #6

gnehapk opened this issue Sep 22, 2016 · 6 comments

Comments

@gnehapk
Copy link
Member

gnehapk commented Sep 22, 2016

Reasons -

  • Flexbox is content driven model. It does not need to know the content upfront.
  • Contents can be redistributed.
  • Allow boxes to wrap which is really handy for responsive design.
@gnehapk gnehapk changed the title Using flexbox instead of grid layout Using flexbox instead of floating grid Sep 27, 2016
@nthomas-redhat
Copy link
Contributor

why not patternfly? Is there any issues/challenges?

@shtripat
Copy link
Member

Also as per guidelines from UX team, UI has to be patternfly compliant.

@gnehapk
Copy link
Member Author

gnehapk commented Sep 30, 2016

Patternfly provides us with good grid system which is good and suitable in dashboards and other form pages, but when it comes to the listing pages a good number of alignment issues has been faced in the skyrings web interface. Currently patternfly relies on Bootstrap grid system, which is based on floats. We do want to use patternfly for all the features it brings, but not having flexbox layouts are only concern against it.

@nthomas-redhat
Copy link
Contributor

Thanks @gnehapk , @kmkanagaraj
@julienlim, can we have someone from the patternfly team here to understand the plans on this and see whether it is aligning with tendrl upstream release plans? or can you give some insights on this?

@debloper
Copy link
Contributor

debloper commented Oct 3, 2016

To add some more details here (conversation progressed through emails, thanks to @julienlim):

  • The patternfly team did address their motif to base on top of BS4 in near future.
  • The timeline of availability is unknown/TBA (need update, when available)
  • All things considered, we might have to stick with floating grids for now.

So for now, PatternFly is the most fitting solution we have in hand.

@debloper debloper closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@debloper @gnehapk @nthomas-redhat @shtripat and others