Fix doc typos #56
Merged
Fix doc typos #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrand
requested changes
May 4, 2022
| @@ -124,7 +124,7 @@ By default a resource is disposed by calling its `.dispose` method. However if t | |||
|
|
|||
| The resource name is threaded (as per `->`) through the `:dispose` form. Most of the time it will be simply a method or a function. | |||
|
|
|||
| Last, you can introduce intermediate values to use in resource initialization via `:let`: | |||
| Lastly, you can introduce intermediate values to use in resource initialization via `:let`: | |||
There was a problem hiding this comment.
Not really a typo, I think both are valid, no?
There was a problem hiding this comment.
I appreciate you taking a look!
I am not an expert, but I think 'lastly' sounds more natural here. Collins seems to agree:
Lastly has a much more common use. You use it to introduce a final point in a discussion, ask a final question, give a final instruction, or mention a final item in a list.
However, not very significant and perhaps not a typo as you stated, so please let me know if you want this bit reverted.
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few typos I've noticed while reading the docs. Not sure if
string typing(instead ofstrong typing) was intentional - it can work both ways. I'll revert that bit from the PR if it was.