Automated Container Builds & bump to sdk:6.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
dotnet/sdk#251 Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
Signed-off-by: Joost Buskermolen <joost@buskervezel.nl>
|
I'd rather keep all TargetFrameworks, using |
This was referenced Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the images on Docker Hub were a bit behind on the commits made in this repo, which led me to creating a GitHub Action that automates this process. However when building, I encountered some issues due to
<TargetFrameworks>being set tonet5.0;net6.0which I now replaced withnet6.0. I did the same for the Dockerfile, used 6.0 instead of 5 and made it multi-stage.For this to work it needs a few secrets to be configured here in order to succeed:
PERSONAL_ACCESS_TOKENDOCKERHUB_USERNAMEDOCKERHUB_TOKENThe value for
PERSONAL_ACCESS_TOKENcan be acquired from your profile with the following permissions: https://github.com/settings/tokens --> Personal access tokens --> Generate new token:Thanks in advance!