Feature/2.1 upgrade #143
Merged
Feature/2.1 upgrade #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2016
| @@ -19,84 +44,55 @@ <h4 class="md-subhead">with custom headings, columns, and inline editing</h4> | |||
| <th td-data-table-column | |||
| *ngFor="let column of columns" | |||
| [numeric]="column.numeric"> | |||
| {{column.label}} | |||
| { {column.label}} | |||
There was a problem hiding this comment.
Its an angular2 issue where if it finds {{ anywhere in an html file, it passes it to its compiler.
So we need to add a space between them to be able to render it in the highlight component.
| </th> | ||
| <tr td-data-table-row *ngFor="let row of basicData"> | ||
| <td td-data-table-cell (click)="openPrompt(row, 'comments')"> | ||
| <button md-button [class.md-accent]="!row['comments']">{{row['comments'] || 'Add Comment'}}</button> | ||
| <button md-button [class.md-accent]="!row['comments']">{ {row['comments'] || 'Add Comment'}}</button> |
There was a problem hiding this comment.
yup good catch but like Ed said we have to do this to render code snippets in highlight.js for docs
| </td> | ||
| <td td-data-table-cell *ngFor="let column of columns" [numeric]="column.numeric"> | ||
| {{row[column.name]}} | ||
| { {row[column.name]}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade @angular dependencies
Fixes #141
What's included?
angulardependencies to@2.2.1zone.jsto@0.6.25angular-clitobeta.19-3materialtoalpha.10and fixed breaking changes https://github.com/angular/material2/blob/master/CHANGELOG.md#200-alpha10-mithril-hoverboard-2016-11-10[attr.disabled]with no value errors in 2.1.1 angular/angular#12583Test Steps
npm uninstall -g angular-clinpm cache cleannpm install -g angular-cli@latestrm -rf node_modules dist tmpnpm ing serve