feat: move components lib into this repo #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikespudwebb
force-pushed
the
feat/add-components-libs
branch
2 times, most recently
from
f045e45
to
24ad13b
Compare
.github/workflows/deploy-ghpages.yml
Outdated
| - name: Deploy docs to GitHub pages | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GH }} | ||
| run: npm run ghpages:deploy | ||
| - name: Commit storybook for git hub doc site |
There was a problem hiding this comment.
one extra step here. we will need will need to checkout the branch gh-pages before doing anything. we might also want to the folder name as storybook-static here.
There was a problem hiding this comment.
Thanks for the feedback. I added the storybook stuff into the github script. Please let me know if that looks alright, @owilliams320.
owilliams320
previously approved these changes
Aug 31, 2022
* Moved over from odubya/covalent-sigma. * Storybook running for components lib. * Fix dialog example page so that the buttons actually open the dialogs now.
mikespudwebb
force-pushed
the
feat/add-components-libs
branch
from
24ad13b
to
d7e6896
Compare
owilliams320
approved these changes
Sep 1, 2022
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Steps
npm run storybookGeneral Tests for Every PR
npm run lintpasses.npm testpasses and code coverage is not lower.Screenshots or link to StackBlitz/Plunker