Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*BREAKING CHANGE* feature(deploy): single core package. closes(#166 and #93) #201

Merged
merged 25 commits into from
Dec 20, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Dec 19, 2016

Description

#93
Pulling all covalent core components into a single package under @covalent/core
Fixes #166

What's included?

  • Single import pkg @covalent/core
  • Created submodules of all core modules which are wrapped by one parent module (CovalentCoreModule)
    • CovalentCommonModule
    • CovalentChipsModule
    • CovalentDataTableModule
    • CovalentDialogsModule
    • CovalentExpansionPanelModule
    • CovalentFileModule
    • CovalentJsonFormatterModule
    • CovalentLayoutModule
    • CovalentLoadingModule
    • CovalentMediaModule
    • CovalentPagingModule
    • CovalentSearchModule
    • CovalentStepsModule
  • Re haul of files internally
  • New location for platform.css:

Before:
@covalent/core/styles/platform.scss

After:
@covalent/core/common/platform.scss

  • New location for all-theme theming and usage of only core component themes`

Before:
~@covalent/core/styles/theming/all-theme';

After:
~@covalent/core/theming/all-theme';

  • markdown needs to be imported separatly ~@covalent/markdown/markdown-theme'

Test Steps

  • ng test
  • ng serve
  • npm run tslint
  • npm run build

@emoralesb05 emoralesb05 changed the title *BREAKING CHANGE* feature(deploy): single core package *BREAKING CHANGE* feature(deploy): single core package. closes(#166 and #93) Dec 19, 2016
@richavyas richavyas self-assigned this Dec 19, 2016
@richavyas
Copy link
Collaborator

LGTM!!

@jeremysmartt
Copy link
Collaborator

jeremysmartt commented Dec 20, 2016

Change Nucleus to Common and then LGTM

@emoralesb05
Copy link
Contributor Author

  • Changed CovalentNucleusModule into CovalentCommonModule

@emoralesb05 emoralesb05 added this to the Alpha 0.10 milestone Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants