-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*BREAKING CHANGE* feature(deploy): single core package. closes(#166 and #93) #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoralesb05
changed the title
*BREAKING CHANGE* feature(deploy): single core package
*BREAKING CHANGE* feature(deploy): single core package. closes(#166 and #93)
Dec 19, 2016
LGTM!! |
Change Nucleus to Common and then LGTM |
|
kyleledbetter
approved these changes
Dec 20, 2016
This was referenced Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#93
Pulling all covalent core components into a single package under
@covalent/core
Fixes #166
What's included?
@covalent/core
platform.css
:Before:
@covalent/core/styles/platform.scss
After:
@covalent/core/common/platform.scss
all-theme
theming and usage of onlycore
component themes`Before:
~@covalent/core/styles/theming/all-theme';
After:
~@covalent/core/theming/all-theme';
markdown
needs to be imported separatly~@covalent/markdown/markdown-theme'
Test Steps
ng test
ng serve
npm run tslint
npm run build