Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): upgrade storybook and fix the source code issue #12

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Jun 14, 2024

Description

When we open a story and click on Show code, storybook shows the minified names of React components instead of actual names.

This issue is only seen in the deployed version of storybook. The localhost version works fine.

Screenshot 2024-06-14 at 11 50 46 AM

What's included?

  • Fixed issue with Component names in the Show code section.
  • Upgrade storybook to the latest version.

Test Steps

  • nx run react-components:storybook
  • Navigate to any story and click on 'Show code`
  • Correct component names should be rendered.

General Tests for Every PR

  • nx run react-components:storybook still works.
  • nx run react-components:build-storybook still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-06-14 at 11 58 41 AM

Header action buttons

Screenshot 2024-06-14 at 1 05 05 PM Screenshot 2024-06-14 at 1 05 19 PM

@owilliams320 owilliams320 merged commit e333ac5 into main Jun 14, 2024
7 checks passed
@owilliams320 owilliams320 deleted the fix/storybook-source-code branch June 14, 2024 18:46
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants