Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user-profile): Theme toggle improvements #123

Closed
wants to merge 1 commit into from
Closed

feat(user-profile): Theme toggle improvements #123

wants to merge 1 commit into from

Conversation

9inpachi
Copy link

@9inpachi 9inpachi commented Sep 8, 2020

Hi,

Used more natural (and intuitive) icons for the light and dark modes. And made it so the dropdown doesn't close on changing the theme since users often want to quickly toggle and check between the two modes (like myself).

Before:

user-profile-menu-before

After:

user-profile-menu-after

Let me know if this is undesired. :)

Thanks.

@adamnel
Copy link
Collaborator

adamnel commented Sep 17, 2020

I'd avoid changing the standard interaction for a menu to suit a specific context - it's more important that the item behaves consistently than that it saves a click in this specific scenario.

With respect to the icon choice, I think we do have an opportunity to tweak it, but I'd follow Google's own decisions here:
image

These are visible in the footer of https://support.google.com/

@9inpachi
Copy link
Author

@adamnel I see. That makes a lot of sense.
I will close the PR then.
Thanks.

@9inpachi 9inpachi closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants