Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-switcher): scroll on expansion #99

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

christianmemije
Copy link
Contributor

Scroll applications into view on expand

@aqupriyanka
Copy link

Sometimes its not working and sometimes its working on second click. Attached the gif for reference.
app_switcher_bug

@adamnel
Copy link
Collaborator

adamnel commented May 29, 2020

@christianmemije The entire dialog should just get longer if need be, not scroll. This could be used in the edge case where we run out of room if we have a very long list.

@christianmemije
Copy link
Contributor Author

@christianmemije The entire dialog should just get longer if need be, not scroll. This could be used in the edge case where we run out of room if we have a very long list.

This is for an edge-case. The menu does increase size. It's just that the max-height of .td-menu-content is set to 50vh within Covalent.

@emoralesb05
Copy link
Collaborator

Isnt the height defined in mat-menu?

@christianmemije
Copy link
Contributor Author

@emoralesb05
Copy link
Collaborator

emoralesb05 commented Jun 1, 2020

Oh, i thought it came from mat-menu.. if thats the case we need to remove that. And make it so that the height its decided on implementation.

Edit: Well, potentially would be to remove it. We just need to make sure we dont break usage since its technically a breaking change.

@christianmemije
Copy link
Contributor Author

Oh, i thought it came from mat-menu.. if thats the case we need to remove that. And make it so that the height its decided on implementation.

Edit: Well, potentially would be to remove it. We just need to make sure we dont break usage since its technically a breaking change.

Opened Teradata/covalent#1765

@christianmemije christianmemije merged commit ed27635 into develop Jun 1, 2020
@christianmemije christianmemije deleted the fix/scroll-app-switcher branch June 1, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants