Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve checkstyle problems #34

Merged
merged 3 commits into from Dec 5, 2021
Merged

chore: resolve checkstyle problems #34

merged 3 commits into from Dec 5, 2021

Conversation

pollend
Copy link
Member

@pollend pollend commented Dec 5, 2021 •
edited

ref: #33

jdrueckert
jdrueckert previously approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdrueckert jdrueckert dismissed their stale review December 5, 2021 19:34

still some checkstyle findings left

@pollend pollend merged commit 4003dff into feat/migrate-eventsystem-gestaltv7 Dec 5, 2021
@pollend pollend deleted the chore/resolve-checkstyle-problems branch December 5, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert jdrueckert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pollend @jdrueckert