Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fleeing entities must have a CharacterMovement component #85

Merged
merged 2 commits into from
Dec 2, 2021
Merged

fix: fleeing entities must have a CharacterMovement component #85

merged 2 commits into from
Dec 2, 2021

Commits on Dec 2, 2021

  1. fix: fleeing entities must have a CharacterMovement component 

    **Problem:** An entity with a death animation may already be stripped off its CharacterMovementComponent when receiving additional damage. This may cause an NPE when accessing the component without guarding check.

**Solution:** Require the CharacterMovementComponent in the event handler to ensure that it is present. Skip the event handler if the component is not present, as fleeing without character movement does make much sense anyways.
    @skaldarnar
    skaldarnar committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    0b89ab9 View commit details
    Browse the repository at this point in the history

  2. doc: add parameter description for event

    @jdrueckert
    jdrueckert committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e498a3e View commit details
    Browse the repository at this point in the history